Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return deduplicationId to callers of enqueue() and enqueueBatch() #64

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

ryanwitt
Copy link
Member

@ryanwitt ryanwitt commented May 10, 2024

Closes suredone/suredone#10368
Closes suredone/suredone#10541

Some callers (internal user) want to reference deduplication ids.

qa / merge notes

  • passes tests
  • provide prototype for php side

@ryanwitt ryanwitt self-assigned this May 10, 2024
@ryanwitt ryanwitt marked this pull request as draft May 10, 2024 00:26
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (0bd632f) to head (fb5739a).

Files Patch % Lines
src/enqueue.js 89.74% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #64      +/-   ##
==========================================
+ Coverage   69.81%   70.24%   +0.43%     
==========================================
  Files          12       12              
  Lines        1100     1126      +26     
  Branches      267      270       +3     
==========================================
+ Hits          768      791      +23     
- Misses        255      258       +3     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanwitt ryanwitt force-pushed the return-deduplication-ids branch from 0ce4eeb to 0b4c9f7 Compare June 12, 2024 15:54
@ryanwitt ryanwitt marked this pull request as ready for review June 12, 2024 16:09
@jasonspalace jasonspalace merged commit efb72b9 into v2 Jun 18, 2024
6 checks passed
@jasonspalace jasonspalace deleted the return-deduplication-ids branch June 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants