fix bug where failed change/deletes were kept around, tuning

suredone · May 14, 2024 · e0b3ca5 · e0b3ca5
1 parent 21d193b
commit e0b3ca5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/consumer.js b/src/consumer.js
@@ -36,7 +36,7 @@ export async function getMessages (qrl, opt, maxMessages) {
     MaxNumberOfMessages: maxMessages,
     MessageAttributeNames: ['All'],
     QueueUrl: qrl,
-    VisibilityTimeout: 60,
+    VisibilityTimeout: 120,
     WaitTimeSeconds: opt.waitTime
   }
   const response = await getSQSClient().send(new ReceiveMessageCommand(params))

diff --git a/src/scheduler/jobExecutor.js b/src/scheduler/jobExecutor.js
@@ -168,6 +168,8 @@ export class JobExecutor {
           console.error('FAILED_MESSAGES', result.Failed)
           for (const failed of result.Failed) {
             console.error('FAILED_TO_EXTEND_JOB', this.jobsByMessageId[failed.Id])
+            // ensure that we clean this one up so it doesn't generate api calls
+            this.jobsbymessageid[failed.id].status = 'failed'
           }
         }
         if (result.Successful) {
@@ -210,6 +212,8 @@ export class JobExecutor {
           console.error('FAILED_MESSAGES', result.Failed)
           for (const failed of result.Failed) {
             console.error('FAILED_TO_DELETE_JOB', this.jobsByMessageId[failed.Id])
+            // ensure that we clean this one up so it doesn't generate api calls
+            this.jobsbymessageid[failed.id].status = 'failed'
           }
         }
         if (result.Successful) {
@@ -250,7 +254,7 @@ export class JobExecutor {
 
   addJob (message, callback, qname, qrl) {
     // Create job entry and track it
-    const defaultVisibilityTimeout = 60
+    const defaultVisibilityTimeout = 120
     const job = {
       status: 'waiting',
       start: new Date(),