forked from ceph/ceph-csi
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noload option appended #7
Open
EnvyusKennys
wants to merge
22
commits into
supremind:atom-v3.3.1
Choose a base branch
from
EnvyusKennys:atom-v3.3.1
base: atom-v3.3.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houz42
reviewed
Mar 11, 2022
houz42
requested changes
Mar 14, 2022
houz42
requested changes
Apr 19, 2022
houz42
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
可以合并了吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Adding noload option for readonly mount condition to avoid journal replay
Provide any external context for the change, if any.
From log:
Warning FailedMount 20m kubelet MountVolume.MountDevice failed for volume "pvc-5841825d-31fc-49af-b7f6-dfaefadc7daf" : rpc error: code = Internal desc = 'fsck' found errors on device /dev/rbd1 but could not correct them: fsck from util-linux 2.32.1
/dev/rbd1: Superblock needs_recovery flag is clear, but journal has data.
/dev/rbd1: Run journal anyway
/dev/rbd1: UNEXPECTED INCONSISTENCY; RUN fsck MANUALLY.
Related issues
Future concerns
May need further testing in prd environments