Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to work with latest versions of Azure/azure-storage-ruby and thotbot/paperclip #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kinkade
Copy link

@kinkade kinkade commented Aug 17, 2017

azure-storage-ruby has a breaking change: #create_blob_block was renamed to #put_blob_block.

https://github.com/Azure/azure-storage-ruby/blob/master/BreakingChanges.md

Also it looks like paperclip has changed Paperclip::Storage::AzureRegion to Paperclip::Storage::Azure::Environment.

The changes in this PR got my app back working again.

documented in:

https://github.com/Azure/azure-storage-ruby/blob/master/BreakingChanges.md

The most notable is that the create_blob_block method was renamed to put_blob_block.
@dannytip
Copy link

dannytip commented Sep 7, 2017

Please can this get merged?

@dannytip
Copy link

dannytip commented Sep 7, 2017

There is also a missing gemspec file here - kinkade@baa18e6

@jordanyaker
Copy link
Contributor

@dannytip thanks for digging in to this. I'll have time this afternoon to check this out more in depth.

Regarding the Gemspec: it's not missing. Since I switched to using Hoe it's no longer part of the base project files. Instead it's part of the generated output.

@dannytip
Copy link

Not having a gemspec file means you can't link to this repo and/or a branch tag from your bundler file. I.e.

gem 'paperclip-azure', github: 'supportify/paperclip-azure', branch: 'example'

Changes were done by @kinkade not me. Thanks goes to him.

@kinkade
Copy link
Author

kinkade commented Sep 11, 2017

That's exactly right, @dannytip That's why I added an extra branch just so that I could use it in my apps.

For others reading this thread, add this to your Gemfile:

gem 'paperclip-azure', git: "https://github.com/kinkade/paperclip-azure", branch: "api_update_azure_storage"

@dannytip
Copy link

Ive been using your branch @kinkade thanks very much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants