Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bulk import docs #790

Closed
wants to merge 2 commits into from
Closed

feat: Add bulk import docs #790

wants to merge 2 commits into from

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Apr 17, 2024

Summary of change

(A few sentences about this PR)

Related issues

Checklist

  • Algolia search needs to be updated? (If there is a new sub docs project, then yes)
  • Sitemap needs to be updated? (If there is a new sub docs project, then yes)
  • Checked for broken links? (Run cd v2 && MODE=production npx docusaurus build)
  • Changes required to the demo apps corresponding to the docs?

@anku255 anku255 marked this pull request as draft April 17, 2024 10:36
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
🔨 Latest commit 3f024b8
🔍 Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/6630a8a2c303ad00085e87e2
😎 Deploy Preview https://deploy-preview-790--admiring-bhabha-7b1be9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

v2/emailpassword/migration/about.mdx Outdated Show resolved Hide resolved
v2/emailpassword/migration/about.mdx Outdated Show resolved Hide resolved
v2/emailpassword/migration/about.mdx Outdated Show resolved Hide resolved
"loginMethods": [
{
"recipeId": "emailpassword",
"tenantIds": ["public"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should tenantIds with ["public"] be a mandatory input? this would be applicable only for importing multi-tenant users right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not a mandatory input. I only included it make it obvious that the users will be imported to the public tenant.

Comment on lines +13 to +16
{
"users": {
"type": "array",
"items": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to render this in some way? it's way too confusing. People who don't know about json schema, won't even understand this.


## Examples

### Example 1: Sample Bulk User Import JSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you must provide many more examples. All in one examples might not be very effective. It should be a step by step additions.

For example:
Start with a very simple use case, of importing emailpassword users only. then, thirdparty users.
Then probably add an example on how to assign user roles. Later metadata.
Then give examples of account linking where same user has different login methods. Talk about isPrimary. Talk about where to add user roles and metadata.

Think about this in more detail please.

@@ -0,0 +1,253 @@
---
id: bulk-user-import
title: Bulk User Import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page should probably called user accounts migration


## Step 3: Monitor the import status

Monitor the import status with a GET request to the bulk import API. Filter the response using the `status` query parameter, which can be 'NEW', 'PROCESSING', or 'FAILED'. Completed entries are automatically deleted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should talk about when the import is going to happen. This is because it won't happen as soon as the bulk-import API is called. It should be clear on when the user can check for the statuses. Also is it possible for the user to know if the users list he passed has been processed or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@anku255 anku255 closed this May 29, 2024
@anku255 anku255 deleted the feat/bulk-import branch May 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants