修复UnhandledPromiseRejection #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions
* handleResult(err, result) and originCallback(err, result) will result
in UnhandledPromiseRejection. eg:
getBrandWCPayRequestParams: two errors from unifiedOrder,
one in callback, handled,
another is the rejected promise, not catched,
UnhandledPromiseRejection
unifiedOrder: error handled in callback ↑
_signedQuery: two errors from validate, ↑
one in callback, handled,
another is the rejected promise, not catched,
UnhandledPromiseRejection
validate: throw ProtocolError ↑
Two UnhandledPromiseRejection in the example above,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在Promise中同时调用handleResult和originCallback, 调用方需要同时处理两个地方的异常，可能导致UnhandledPromiseRejection, eg:
getBrandWCPayRequestParams:需要处理来自unifiedOrder的两个错误(callback and rejected promise), 只处理了callback
UnhandledPromiseRejection
unifiedOrder:↑只需要处理callback中的error
_signedQuery:↑需要处理来自validate的两个错误(callback and rejected promise), 只处理了callback
UnhandledPromiseRejection
validate:↑抛出错误
(总共有两个UnhandledPromiseRejection)