[bugfix] Always serialize orderedItems
as array in OrderedCollection
#1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements a workaround for an issue where orderedItems in a featured/pinned collection would be serialized as a string (instead of a string array) if there was only one entry. This was causing issues with other implementations that assume that orderedItems will always be an array (which is apparently the correct behavior).
See mastodon/mastodon#24225 and go-fed/activity#139
Note: while this code gets us moving for now, it is far from a perfect solution because a) it's confusing and b) it's inefficient. We should definitely pull this code out if/when we get it fixed in go-fed.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.