fix: openai python sdk package export

[CodeWithShreyans]

No description provided.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	supermemory-app	1c8b037	Commit Preview URL Branch Preview URL	Sep 20 2025, 09:52 PM

[CodeWithShreyans]

• fix: openai python sdk package export #432 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review Feedback

✅ Positive Changes

• Proper package structure: Moving files to src/supermemory_openai/ creates a proper Python package structure
• Version bump: Incrementing to 1.0.2 is appropriate for a packaging fix
• Dependency update: Updating supermemory>=3.1.0 suggests compatibility improvements
• Type improvements: Using ChatCompletionFunctionToolParam instead of generic ChatCompletionToolParam provides better type safety

🔧 Technical Issues

1. Breaking Import Path (Critical)

The existing tests are importing from supermemory_openai_sdk but the package structure suggests it should be supermemory_openai. This could break existing users:

# Current test imports (line 16)
from supermemory_openai_sdk import SupermemoryTools
# But package structure suggests:
from supermemory_openai import SupermemoryTools

Recommendation: Verify the intended import path and ensure backward compatibility.

2. Removed Version Constant

The __version__ = "0.1.0" was removed from __init__.py. This breaks runtime version checking:

# This will now fail:
import supermemory_openai
print(supermemory_openai.__version__)

Recommendation: Re-add version constant or use dynamic version from pyproject.toml.

3. Build Configuration Issues

The build configuration changes may not work as expected:

# Old (explicit)
[tool.hatch.build.targets.wheel]
packages = ["src"]

# New (potentially problematic)  
[tool.hatch.build]
include = ["src/*"]
[tool.hatch.build.targets.wheel]
packages = ["src/supermemory_openai"]

Recommendation: Test the build process to ensure the package structure is correct.

🧪 Test Coverage Concerns

1. Import Path Tests: The test file has fallback import logic that may mask packaging issues
2. No packaging tests: Missing tests to verify the actual package installation and imports work correctly
3. Version testing: No tests for version accessibility

Recommendations:

• Add tests that verify correct import paths after package installation
• Add version accessibility tests
• Test the actual package build and installation process

🛡️ Security & Best Practices

Good practices maintained:

• No hardcoded credentials or secrets
• Type safety improvements with specific OpenAI types
• Proper dependency versioning

Areas for improvement:

• Consider adding py.typed file for better type checking support
• The removed Black configuration may affect code consistency

⚡ Performance Considerations

• Changes appear to be packaging-only with no performance impact
• Type improvements may provide better IDE support and error catching

🔍 Additional Recommendations

1. Add migration guide: Document the import path changes for existing users
2. Test thoroughly: Verify package builds, installs, and imports correctly in a clean environment
3. Version management: Consider using importlib.metadata or similar for dynamic version access
4. Documentation update: Ensure README reflects correct import paths

⚠️ Priority Issues to Address

1. Critical: Resolve import path inconsistency between tests and package structure
2. High: Re-add __version__ attribute for runtime access
3. Medium: Verify build configuration produces correct package structure

The changes improve the package structure but introduce potential breaking changes that need careful testing and documentation.

[graphite-app]