Fix : Dockerfile URL handling in flyctl #4506
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for downloading Dockerfiles from URLs (http/https) - Fix issue where URLs were treated as local paths and concatenated with working directory - Add URL detection and download functionality in resolveDockerfilePath - Update dockerfile_builder to handle temporary files from downloaded URLs - Add comprehensive unit tests for URL handling and download functionality Fixes superfly#4464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
internal/command/deploy/deploy_build.go: AddedisURL(),downloadFile()functions and updatedresolveDockerfilePath()to handle URLsinternal/build/imgsrc/dockerfile_builder.go: AddedisDockerfileURL()helper and updated file existence checksinternal/command/deploy/dockerfile_url_test.go: Added comprehensive unit testsFixes #4464
Change Summary
What and Why:
How:
Related to:
Documentation