fix: nil pointer reference setMachineReleaseData #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankittk
force-pushed
the
fix-nil-pointer-deference-fly-secret
branch
from
73c505e to
317c57e
Compare
ankittk
force-pushed
the
fix-nil-pointer-deference-fly-secret
branch
from
317c57e to
1874885
Compare
ankittk
force-pushed
the
fix-nil-pointer-deference-fly-secret
branch
from
1874885 to
288fbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Fix a potential nil panic when accessing app.Role in the setMachineReleaseData function.
In some cases, md.app could be nil, leading to a runtime panic during deploys or restarts.
How:
Added a nil check, nothing else
Related to: #4190
Documentation