Use hujson to load MCP list from settings.json, allowing JSON comments. Closes #4430 #4485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
I modified the code (.//internal/command/mcp/list.go) that loads the settings.json file to use hujson, a library that extends standard JSON parsing with support for:
Because encoding/json, that was being used earlier, doesnt allow comments in json files which was causing issues.
How:
I replaced the standard json.Unmarshal flow with a new pipeline using hujson
Related to: #4430
Documentation