Fix Dockerfile URL support in build configuration #4470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where flyctl would incorrectly treat URLs specified in the [build] section's dockerfile parameter as local paths, causing builds to fail with "Dockerfile not found" errors. Changes: - Add URL detection for Dockerfile paths in resolveDockerfilePath() - Implement downloadDockerfileFromURL() to fetch Dockerfiles from URLs - Add comprehensive tests for URL and local path handling - Support both HTTP and HTTPS URLs with proper error handling Fixes: #4464 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
kzys
reviewed
Jul 10, 2025
| // Download the Dockerfile | ||
| resp, err := http.Get(dockerfileURL) | ||
| if err != nil { | ||
| os.Remove(tempFile.Name()) |
There was a problem hiding this comment.
Can you move os.Remove() to defer? You can check err in defer to see whether the function is successfully finished or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[build]section as local pathsChanges Made
resolveDockerfilePath()to detect and handle HTTP/HTTPS URLsdownloadDockerfileFromURL()to download Dockerfiles from URLs to temporary filesisURL()helper function to validate URL formatTest Coverage
Fixes
Closes #4464
Test Plan
🤖 Generated with Claude Code