pubsub: fix a subtle race in catch up logic for barely active subs #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of events processing when Corrosion is handling a change is:
When Corrosion client is catching up it subscribes to changes sent to
the channel and queries the full sub DB. It's possibly that the query
is run before the changes are committed, but after they've been sent
to the channel, so what happens is:
this change
N - 1, so EndOfQuery{change_id: N - 1} is sent to the client
N
last sent change ID (N) with min_change_id (N) it ignores it becase
the comparison is strictly greater.
min_change_id is what we expect to receive, so the fix is trivial -
comparison should be greater or equal.