Skip to content

fix: re-export Helpers module #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

fix: re-export Helpers module #724

merged 2 commits into from
May 31, 2025

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented May 30, 2025

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

grdsdev added 2 commits May 30, 2025 12:09
@grdsdev grdsdev requested a review from Copilot May 30, 2025 15:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes the import of the Helpers module by removing redundant explicit imports from multiple files and introducing dedicated Exports files to re-export Helpers.

  • Removed explicit "import Helpers" statements throughout Functions and Auth modules.
  • Added Exports.swift files in Sources/Functions and Sources/Auth that re-export the Helpers module.
  • Removed local typealiases for Helpers types in Sources/Auth/Types.swift, which may affect API exposure.

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Sources/Functions/Types.swift Removed explicit "import Helpers".
Sources/Functions/FunctionsClient.swift Removed explicit "import Helpers".
Sources/Functions/Exports.swift Introduced Exports file to re-export Helpers.
Sources/Auth/Types.swift Removed explicit "import Helpers" and local typealiases.
Sources/Auth/Internal/SessionStorage.swift Removed explicit "import Helpers".
Sources/Auth/Internal/SessionManager.swift Removed explicit "import Helpers".
Sources/Auth/Internal/Helpers.swift Removed explicit "import Helpers".
Sources/Auth/Internal/EventEmitter.swift Removed explicit "import Helpers".
Sources/Auth/Internal/Dependencies.swift Removed explicit "import Helpers".
Sources/Auth/Internal/CodeVerifierStorage.swift Removed explicit "import Helpers".
Sources/Auth/Internal/APIClient.swift Removed explicit "import Helpers".
Sources/Auth/Exports.swift Introduced Exports file to re-export Helpers.
Sources/Auth/Deprecated.swift Removed explicit "import Helpers".
Sources/Auth/Defaults.swift Removed explicit "import Helpers".
Sources/Auth/AuthStateChangeListener.swift Removed explicit "import Helpers".
Sources/Auth/AuthMFA.swift Removed explicit "import Helpers".
Sources/Auth/AuthError.swift Removed explicit "import Helpers".
Sources/Auth/AuthClientConfiguration.swift Removed explicit "import Helpers".
Sources/Auth/AuthClient.swift Removed explicit "import Helpers".
Sources/Auth/AuthAdmin.swift Removed explicit "import Helpers".
Comments suppressed due to low confidence (1)

Sources/Auth/Types.swift:2

  • The removal of local typealiases from Helpers (e.g., AnyJSON, JSONObject) alters the API exposure; ensure that this change is intentional and update the migration guide if consumers rely on these aliases.
import Helpers

// Created by Guilherme Souza on 30/05/25.
//

@_exported import Helpers
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment above the re-export line to document how and when to use this module re-export, to ease the transition for developers.

Copilot uses AI. Check for mistakes.

// Created by Guilherme Souza on 30/05/25.
//

@_exported import Helpers
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] It may be helpful to include usage notes in this file detailing that Consumers should import this file instead of directly importing Helpers.

Copilot uses AI. Check for mistakes.

@grdsdev grdsdev marked this pull request as ready for review May 30, 2025 15:16
@grdsdev grdsdev requested a review from dshukertjr May 30, 2025 15:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15349830757

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 75.652%

Totals Coverage Status
Change from base Build 15301720131: 0.004%
Covered Lines: 5223
Relevant Lines: 6904

💛 - Coveralls

@grdsdev grdsdev merged commit fd97d99 into main May 31, 2025
42 of 43 checks passed
@grdsdev grdsdev deleted the fix/exports branch May 31, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants