feat(realtime): add heartbeat callback #709
Merged
+131
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
force-pushed
the
guilherme/clibs-158-supabase-swift-add-heartbeat-callback
branch
from
e927454 to
2ab61f6
Compare
Pull Request Test Coverage Report for Build 14715004040Details
💛 - Coveralls |
grdsdev
requested review from
filipecabaco and
Copilot
and removed request for
filipecabaco
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for heartbeat callbacks to the realtime client and includes corresponding tests. Key changes include the introduction of a new HeartbeatStatus enum, modifications to the heartbeat sending and handling logic in RealtimeClientV2, and updates to test cases to verify heartbeat behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/RealtimeTests/RealtimeTests.swift | Added new tests for heartbeat responses and timeout behavior. |
| Sources/Realtime/Types.swift | Introduced the HeartbeatStatus enum to represent heartbeat events. |
| Sources/Realtime/RealtimeClientV2.swift | Updated heartbeat logic, channel storage (from array to dictionary), and associated reconnection handling. |
Comments suppressed due to low confidence (1)
Sources/Realtime/RealtimeClientV2.swift:505
- [nitpick] The previous implementation returned all channels with the matching topic using a filter. Please confirm that restricting to a single channel (via the dictionary lookup) is intended, ensuring that multiple channels per topic are not expected.
return $0.channels[message.topic]
Co-authored-by: Copilot <[email protected]>
grdsdev
force-pushed
the
guilherme/clibs-158-supabase-swift-add-heartbeat-callback
branch
from
5cd006e to
cb60535
Compare
dshukertjr
approved these changes
Apr 29, 2025
grdsdev
deleted the
guilherme/clibs-158-supabase-swift-add-heartbeat-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.