fix: switch from jsonwebtoken to jose for jwt signing/verification #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14644113930Details
💛 - Coveralls |
- Supports async jwt signing/verification using libuv - Add support for OKP (ed25519/Ed448) jwks - Cleaner implementation across jwt code
itslenny
force-pushed
the
fix/switch-from-jsonwebtoken-tojose
branch
from
1dfa516 to
7bd2b6c
Compare
fenos
reviewed
Apr 25, 2025
| // Generate a 64-byte random key, convert the secret key to Base64URL encoding (JWK standard) | ||
| const k = crypto.randomBytes(64).toString('base64url') | ||
| return { kty: 'oct', alg: 'HS256', k } | ||
| export async function generateHS512JWK(): Promise<JwksConfigKeyOCT> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix / enhancement
What is the current behavior?
We currently use jsonwebtoken for signing JWTs which is fully synchronous even when using the callback pattern
What is the new behavior?
Switch to jose for jwt signing which uses libuv to sign jwts asynchronously. Also, adds support for OKP (ed25519/Ed448) jwks.