testinfra: Fix InstanceType and startup error handling#2207
Open
mmlb wants to merge 2 commits into
Open
Conversation
This is used to get logs from journalctl but when the service name is wrong there's nothing to report and thus is very unhelpful.
This comment has been minimized.
This comment has been minimized.
Contributor
|
@claude review |
hunleyd
approved these changes
Jun 10, 2026
OrioleDB can't start on such a small instance type due insufficient memory. I chose t3.micro because it had same specs as t4g.micro which hadn't been having any problems. Since then I have seen some arm64 test failures too but did not have any logs from journalctl to debug, I would not be surprised if arm is right at the edge of memory limits.
mmlb
changed the title
|
Found 50 test failures on Blacksmith runners: Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used to get logs from journalctl but when the service name is wrong there's nothing to report and thus is very unhelpful.
What kind of change does this PR introduce?
Buf fix
What is the current behavior?
If testinfra times out waiting on a healthy postgres service it will use journalctl to show last few lines of log, but the service name is wrong therefore the logs are empty. For example see https://github.com/supabase/postgres/actions/runs/27230790541/job/80420986600#step:12:161
What is the new behavior?
Correct systemd service name should give us logs next time we hit this.