-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sam/pgroonga deps #1105
Merged
Merged
Sam/pgroonga deps #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darora
approved these changes
Aug 13, 2024
olirice
approved these changes
Sep 12, 2024
@samrose lgtm, feel free to merge once the conflicts are resolved |
groonga plugins dir must be set as env var for TokenMecab to work
* add mecab test * add mecab test
samrose
force-pushed
the
sam/pgroonga-deps
branch
from
September 13, 2024 17:32
646a6f8
to
bf6c370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
a comment on a PR #462 (comment) reported that in our 15.6 release,
TokenMecab
was no longer working on thepgroonga
extension.This PR restores that Tokenizer capability to the proonga extension, and adds the following test below, which will run on every PR going forward.