Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrappers nix-based pg_upgrade #1104

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: wrappers nix-based pg_upgrade #1104

merged 3 commits into from
Aug 12, 2024

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented Aug 9, 2024

  • The lookup path for nix-based binaries isn't necessarily the obvious one
  • This ensures that a wrappers lib file named as expected to by PG exists on all existing paths

@pcnc pcnc requested a review from a team as a code owner August 9, 2024 14:54
darora
darora approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@darora darora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review this well. Need to move the upgrade scripts to something better tested.

Approving based on your validation runs.

@darora darora merged commit a46d236 into develop Aug 12, 2024
10 of 11 checks passed
@darora darora deleted the pcnc/fix-nix-wrappers-upgrade branch August 12, 2024 05:40
@darora darora restored the pcnc/fix-nix-wrappers-upgrade branch August 12, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darora darora darora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcnc @darora