fix: use query level statement_timeout#947
Merged
Conversation
avallete
force-pushed
the
fix/only-add-statement-timeout-on-direct-connection
branch
from
949f655 to
e41138a
Compare
Pull Request Test Coverage Report for Build 15280901649Details
💛 - Coveralls |
avallete
changed the title
avallete
force-pushed
the
fix/only-add-statement-timeout-on-direct-connection
branch
from
a43da4e to
4150b26
Compare
avallete
commented
May 22, 2025
Comment on lines
+15
to
+16
| // Use dynamic import to support module mock | ||
| const fs = await import('node:fs/promises') |
Member
Author
There was a problem hiding this comment.
note
The dynamic module import need to be within the function to avoid other imports of constant.ts to possibly break the mocks in the tests.
Performance impact should be minimal as we just use it at server startup time.
soedirgo
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Some non direct connectionString (such as pgBouncer or other poolers) won't support the
statement_timeoutparameter being set at connection level.To circumvent that, setting the
statement_timeoutat the query level as a prefix.Make it an optional parameter for the
/queryroute.