Prioritize current schema for pg type generation#939
Merged
avallete merged 2 commits intosupabase:masterfrom May 11, 2025
Merged
Prioritize current schema for pg type generation#939avallete merged 2 commits intosupabase:masterfrom
avallete merged 2 commits intosupabase:masterfrom
Conversation
Pull Request Test Coverage Report for Build 14955777882Details
💛 - Coveralls |
avallete
approved these changes
May 11, 2025
Member
avallete
left a comment
There was a problem hiding this comment.
Looks good, thank's for your contribution !
Contributor
Author
|
Thanks @avallete. When can we release this? I'd love to start using it. |
Member
|
My bad, I wrongly merged without creating a commit that follow the conventional commit which prevented the CD to create and push a new release with those changes. Should be available once this: #939 get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If multiple schemas have enum types with the same name, the generated enum types all use the same schema, which is the first schema returned by pgMeta.types.list().
What is the new behavior?
If the current/self schema has the enum type, generated enum type will use the current schema instead of the first schema.
Additional context
Add any other context or screenshots.