ci(repo): publish preview packages only with run-preview-packages label

.github/MAINTAINERS.md

@@ -51,26 +51,38 @@ issue directly (from the GitHub UI, or from the Linear-linked issue).
 ## `run-ci`: full develop CI on stacked or draft PRs
 
 Ready (non-draft) PRs targeting `develop` already get the default suite: Test
-(check / unit+integration / e2e), preview CLI packages, and PR-title lint.
+(check / unit+integration / e2e) and PR-title lint.
 
 Stacked PRs (base is another PR branch) and drafts do **not** get that suite
 unless they carry the **`run-ci`** label. [`run-ci.yml`](./workflows/run-ci.yml)
-then calls Test and preview-package publish as reusable workflows, including
-while the PR is still a draft.
+then calls Test as a reusable workflow, including while the PR is still a draft.
 
 - Add `run-ci` to start (or resume) the suite; remove it to cancel in-progress
   `run-ci` runs via that workflow's concurrency group.
-- Other labels do not start or cancel Test / preview. PR-title lint may
-  retrigger because that check is cheap.
+- Other labels do not start or cancel Test. PR-title lint may retrigger because
+  that check is cheap.
 - After a stacked PR is retargeted onto `develop`, push or reopen so the
   native required checks (`Check code quality`, etc.) populate. The opt-in
   suite uses different check names (`Test / Check code quality`).
-- This is independent of `run-live-e2e-ci`, which opts into the separate
-  supabox live e2e dispatch.
+- This is independent of `run-preview-packages` and `run-live-e2e-ci`.
 
 The `run-ci` label must exist as a repository label; create it from
 **Issues → Labels** if it is missing.
 
+## `run-preview-packages`: on-demand pkg.pr.new preview
+
+CLI preview packages are large, so they are **not** published on every PR.
+Add the **`run-preview-packages`** label to publish via
+[`publish-preview-cli-packages.yml`](./workflows/publish-preview-cli-packages.yml)
+(any base branch, including drafts). While the label stays on, each subsequent
+push re-publishes; remove it to cancel in-progress runs.
+
+The workflow posts (or updates) a PR comment with an `npx` install command for
+the preview. This is independent of `run-ci` and `run-live-e2e-ci`.
+
+The `run-preview-packages` label must exist as a repository label; create it
+from **Issues → Labels** if it is missing.
+
 ## Deferred: automatic Linear → GitHub label sync
 
 We considered auto-applying `open-for-contribution` when a Linear issue moves out of

.github/workflows/lint-pull-request.yml

@@ -3,9 +3,9 @@ name: Lint Pull Request
 # Release-notes PRs (head ref `release-notes/*`) skip CI; only
 # apply-release-notes.yml runs for those.
 #
-# Draft PRs skip this check unless they carry `run-ci` (same opt-in as Test
-# and preview packages). Label events retrigger this cheap check so adding
-# `run-ci` on a draft starts lint without waiting for a push.
+# Draft PRs skip this check unless they carry `run-ci` (same opt-in as Test).
+# Label events retrigger this cheap check so adding `run-ci` on a draft starts
+# lint without waiting for a push.
 on:
   pull_request_target:
     types:

.github/workflows/publish-preview-cli-packages.yml

@@ -3,44 +3,44 @@ name: Publish Preview CLI Packages
 # Release-notes PRs (head ref `release-notes/*`) are markdown-only and are not
 # meant to produce installable preview packages.
 #
-# Default path: ready (non-draft) PRs targeting `develop`.
-# `run-ci.yml` calls this workflow for drafts and stacked / non-develop PRs.
+# Opt-in by label: pkg.pr.new hosts large CLI binaries, so publish only when
+# someone needs a shareable install. Add `run-preview-packages` to publish
+# (and re-publish on each subsequent push while labeled); remove it to cancel
+# in-progress runs via this workflow's concurrency group.
 on:
   pull_request:
     types:
       - opened
       - synchronize
       - reopened
-      - ready_for_review
-      - converted_to_draft
-    branches:
-      - develop
-  workflow_call:
-    inputs:
-      force:
-        description: Publish even when the PR is a draft (used by run-ci.yml)
-        type: boolean
-        default: false
-    secrets:
-      DF_FIREWALL_TOKEN:
-        required: true
+      - labeled
+      - unlabeled
 
 permissions:
   actions: read
   contents: read
 
-# Literal prefix: called workflows inherit github.workflow from the caller
-# (`run-ci`). `inputs.force` separates this call from a skipped native run on
-# a develop draft.
+# Unrelated label events still start a run; give them a unique group so they
+# cannot cancel an in-progress publish. Removing `run-preview-packages` stays
+# on the main group and cancels via cancel-in-progress.
 concurrency:
-  group: publish-preview-cli-packages.yml-${{ github.event.pull_request.number || github.head_ref }}-${{ inputs.force && 'run-ci' || 'direct' }}
+  group: >-
+    publish-preview-cli-packages.yml-${{ github.event.pull_request.number || github.ref }}${{
+      ((github.event.action == 'labeled' || github.event.action == 'unlabeled')
+        && github.event.label.name != 'run-preview-packages'
+        && format('-noop-{0}', github.run_id))
+      || ''
+    }}
   cancel-in-progress: true
 
 jobs:
   build:
     if: |
       !startsWith(github.head_ref, 'release-notes/') &&
-      (inputs.force || github.event.pull_request.draft == false)
+      contains(github.event.pull_request.labels.*.name, 'run-preview-packages') &&
+      ((github.event.action != 'labeled' &&
+          github.event.action != 'unlabeled') ||
+        github.event.label.name == 'run-preview-packages')
     name: Build preview CLI packages
     uses: ./.github/workflows/build-cli-artifacts.yml
     with:
@@ -51,10 +51,7 @@ jobs:
 
   publish:
     needs: build
-    if: |
-      !startsWith(github.head_ref, 'release-notes/') &&
-      (inputs.force || github.event.pull_request.draft == false) &&
-      needs.build.result == 'success'
+    if: needs.build.result == 'success'
     name: Publish preview package
     runs-on: blacksmith-8vcpu-ubuntu-2404
     outputs:
@@ -135,10 +132,7 @@ jobs:
 
   comment:
     needs: publish
-    if: |
-      !startsWith(github.head_ref, 'release-notes/') &&
-      (inputs.force || github.event.pull_request.draft == false) &&
-      needs.publish.result == 'success'
+    if: needs.publish.result == 'success'
     name: Post preview command comment
     runs-on: ubuntu-latest
     permissions:

.github/workflows/run-ci.yml

@@ -1,11 +1,12 @@
 name: run-ci
 
-# Opt-in full develop CI for PRs that Test.yml / preview do not already cover:
-# stacked PRs (base is not develop) and drafts. Ready develop PRs stay on the
-# existing workflows so required check names and concurrency are unchanged.
+# Opt-in full develop CI for PRs that Test.yml does not already cover: stacked
+# PRs (base is not develop) and drafts. Ready develop PRs stay on the existing
+# workflows so required check names and concurrency are unchanged.
 #
 # Add the `run-ci` label to start the suite; remove it to cancel in-progress
 # runs via this workflow's concurrency group. Other labels do not retrigger.
+# Preview packages are a separate opt-in (`run-preview-packages`).
 on:
   pull_request:
     types:
@@ -20,7 +21,6 @@ on:
 permissions:
   actions: read
   contents: read
-  pull-requests: write
 
 # Unrelated label events still start a run; give them a unique group so they
 # cannot cancel an in-progress suite. Removing `run-ci` stays on the main
@@ -50,18 +50,3 @@ jobs:
       force: true
     secrets:
       DF_FIREWALL_TOKEN: ${{ secrets.DF_FIREWALL_TOKEN }}
-
-  preview:
-    name: Preview packages
-    if: |
-      !startsWith(github.head_ref, 'release-notes/') &&
-      contains(github.event.pull_request.labels.*.name, 'run-ci') &&
-      (github.event.pull_request.draft || github.base_ref != 'develop') &&
-      ((github.event.action != 'labeled' &&
-          github.event.action != 'unlabeled') ||
-        github.event.label.name == 'run-ci')
-    uses: ./.github/workflows/publish-preview-cli-packages.yml
-    with:
-      force: true
-    secrets:
-      DF_FIREWALL_TOKEN: ${{ secrets.DF_FIREWALL_TOKEN }}

.github/workflows/test.yml

@@ -35,9 +35,8 @@ permissions:
   actions: read
 
 # Literal prefix: called workflows inherit github.workflow from the caller
-# (`run-ci`), which would cancel the caller and the preview call. `inputs.force`
-# keeps a skipped native Test run on a develop draft from cancelling the
-# forced run-ci call.
+# (`run-ci`), which would cancel the caller. `inputs.force` keeps a skipped
+# native Test run on a develop draft from cancelling the forced run-ci call.
 concurrency:
   group: test.yml-${{ github.event.pull_request.number || github.head_ref || github.ref }}-${{ inputs.force && 'run-ci' || 'direct' }}
   cancel-in-progress: true