fix(deps): bump github.com/docker/cli from 28.5.2+incompatible to 29.5.3+incompatible in /apps/cli-go#5538
Conversation
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 28.5.2+incompatible to 29.5.3+incompatible. - [Commits](docker/cli@v28.5.2...v29.5.3) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.5.3+incompatible dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Found 125 test failures on Blacksmith runners: Failures
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01a33d857a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| github.com/containerd/errdefs v1.0.0 | ||
| github.com/containers/common v0.64.2 | ||
| github.com/docker/cli v28.5.2+incompatible | ||
| github.com/docker/cli v29.5.3+incompatible |
There was a problem hiding this comment.
Keep Docker CLI and engine client modules aligned
With this bump, github.com/docker/cli v29 has moved its command client API to github.com/moby/moby/client, while this module still requires github.com/docker/docker v28 and internal/utils.NewDocker() asserts cli.Client().(*github.com/docker/docker/client.Client). Any command path importing internal/utils initializes var Docker = NewDocker(), so the CLI is now incompatible with Docker CLI's returned client type unless the Docker engine client imports/require are migrated in the same change.
Useful? React with 👍 / 👎.
Bumps github.com/docker/cli from 28.5.2+incompatible to 29.5.3+incompatible.
Commits
d1c06efMerge pull request #7022 from mickael-docker/docs-request-field7dd053bMerge pull request #7003 from thaJeztah/logs_links37c3d31Merge pull request #7024 from thaJeztah/add_zizmor45f10f2Merge pull request #7025 from vvoland/update-gob458dc9update to go1.26.41953194gha: apply zizmor fixesac0419egha: add zizmor workflow1aa0416docs: recommend default deny and clarify requesturi field3a85952Merge pull request #7020 from thaJeztah/full_semver8d3fbdfMerge pull request #7019 from thaJeztah/dependabot_labelsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)