Conversation
Pull Request Test Coverage Report for Build 23950082888Details
💛 - Coveralls |
seanoliver
left a comment
There was a problem hiding this comment.
Tested locally with PH staging project and everything looks great!
The env_signals property is 🔥 — this is going to be super useful for segmentation.
|
one thing from the telemetry side: the 4 events are defined as inline strings at each call site. on the frontend we have telemetry-constants.ts that acts as a registry for every event with documented properties for each event, which makes it easy to see what's being tracked, keep naming consistent, and lets data people know what to expect without reading through the Go code. would it be possible to add something similar for the CLI? even just a constants file in internal/telemetry/ with all event names and expected properties in one place. makes it way easier for us to track what exists and catch naming issues before they ship |
Closes: CLI-1243