fix: adjust required claims in custom access token hook#1913
Open
fix: adjust required claims in custom access token hook#1913
Conversation
Pull Request Test Coverage Report for Build 12773204803Details
💛 - Coveralls |
hf
commented
Jan 14, 2025
Comment on lines
+103
to
+106
| Email string `json:"email,omitempty"` | ||
| Phone string `json:"phone,omitempty"` | ||
| AppMetaData map[string]interface{} `json:"app_metadata,omitempty"` | ||
| UserMetaData map[string]interface{} `json:"user_metadata,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
Having second thoughts about this change... it could be a breaking change
Member
There was a problem hiding this comment.
yeah i don't think we should add omitempty because this would remove the field entirely from the struct if it's not present vs returning an empty json object currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emailandphoneshould not be required as they are not used by Supabase Auth for anything meaningful. They also don't have to exist (but are probably set as""today) if using just email provider, or just phone provider, or anonymous sign-ins, etc.is_anonymousalso is not required as it depends on whether it's used in RLS policies.issshould be added but it's not as it only makes sense with asymmetric JWTs. Additional validation on this will follow.See: