refactor: drop change.rs <3 #447
Conversation
| /// Creates a child statement ID with the given content and parent content. | ||
| pub fn new_child(child_content: &str, parent_content: &str) -> Self { | ||
| StatementId::Child { | ||
| content: child_content.into(), | ||
| parent_content: parent_content.into(), | ||
| } |
There was a problem hiding this comment.
Is this used/needed? feels like we could create orphaned childs with this – not a problem right now, but maybe leads to confusion in the future?
| } | ||
| } | ||
|
|
||
| pub fn parent(&self) -> Option<StatementId> { | ||
| pub fn content(&self) -> &str { |
| @@ -641,9 +637,9 @@ impl Workspace for WorkspaceServer { | |||
| }); | |||
|
|
|||
| tracing::debug!( | |||
| "Found {} completion items for statement with id {}", | |||
| "Found {} completion items for statement with id {:?}", | |||
There was a problem hiding this comment.
that's probably a lot of log output – not sure we even need the print
crates/pgt_lsp/src/capabilities.rs
Outdated
| /// Instead, we manually list the command IDs we want to register. | ||
| fn available_command_ids() -> Vec<String> { | ||
| vec
as per PR title. notable changes:
change.rsin favour of a simpleupdate_documentapi that replaces the contentStatementIdto just be a simple wrapper around the actual statement string. The content is wrapped in anArc<str>to make cloning cheap. turns out string interning only makes sense when we have a lot of duplicate strings.Arc<str>is much more efficient and simpler in our case.document.rsand merge it intoparsed_documentto then rename it toDocumentstrumusage to get the available command because it didn't feel right to make an empty string the default for a StatementId. replaced it with a simple manual implementation.I ran a few benchmarks and the statement splitter performance seems to be good enough to run it on every keystroke on the entire file.
large statement with length 863000 time: [23.180 ms 23.278 ms 23.386 ms] small statement with length 19000 time: [886.69 µs 890.91 µs 896.35 µs]ToDo