Add CDAWeb CDF support for WIND and STEREO by Amityush-lgtm · Pull Request #254 · sunpy/radiospectra

Amityush-lgtm · 2026-07-07T07:41:29Z

PR Description

Fixes #199
This PR adds support for reading CDAWeb CDF files

Changes:

Added parsing logic to _read_cdf to handle WIND WAVES (RAD1/RAD2) files sourced from CDAWeb.
Added parsing logic for STEREO S/WAVES (LFR/HFR).
Added mock tests for both WIND and STEREO CDAWeb parsing.

AI Assistance Disclosure

AI tools were used for:

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
No AI tools were used

Regardless of AI use, the human contributor remains fully responsible for correctness, design choices, licensing compatibility, and long-term maintainability.

samaloney · 2026-07-07T11:25:30Z

+            raw_freqs = cdf.varget("FREQUENCY")
+            freq_fill = cdf.varattsget("FREQUENCY").get("FILLVAL", -1e31)
+            valid_freq_mask = raw_freqs > freq_fill
+            freqs = raw_freqs[valid_freq_mask] << u.Unit(cdf.varattsget("FREQUENCY").get("UNITS", "Hz"))


Hum the fill value isn't used is it? Maybe do the assignment and filling the convert to a unit?

Got it, working on the assignment. One doubt, what should i use to replace the fill values?? np.nan or 0???

Amityush-lgtm · 2026-07-07T13:50:30Z

I've pushed an update using np.nan for the fill value for now, let me know what you think

hayesla

this is looking good! there are two small bugs thought when I tested it with the real data files.

also could you add tests for teh two new data file paths? (using @pytest.mark.remote_data tests), an online test against a real CDAWeb file would cover the real parsing (and would have caught the two plotting issues I raised here)

Amityush-lgtm · 2026-07-13T10:45:39Z

this is looking good! there are two small bugs thought when I tested it with the real data files.

also could you add tests for teh two new data file paths? (using @pytest.mark.remote_data tests), an online test against a real CDAWeb file would cover the real parsing (and would have caught the two plotting issues I raised here)

Thanks for testing this, i'll update the frequency handling accordingly and add online cdaweb tests for both the WIND and STEREO paths so we can cover the real parsing as well.

Amityush-lgtm · 2026-07-27T19:21:43Z

It seems the failure was due to a deprecation warning in cdflib with newer NumPy version and this one is due to server issue ig, i have added a warning filter to it

Hermanlrx · 2026-07-28T09:47:56Z

+
+                    meta = {
+                        "cdf_globals": cdf_globals,
+                        "detector": "LFR+HFR",


Im not too familiar with this data product or instruments but I think it makes sense to be able to read and plot the data from the different detectors separately. Unless it's only given by the instrument team as one file I can imagine a world where you would also like one without the other?

Maybe the data can be separated using crop_freq() to get specific frequency range

hmmm true, it looks like the freq ranges overlap though (10-160 kHz and 125kHz - 16MHz), I would vote to separate them but @samaloney or @hayesla might have better perspective

I guess the question for @Amityush-lgtm is where did you get "LFR+HFR" from to hardcode in here? i think this reader works on one file (rather than seperate HFR+LFR files so i think its ok

I wrote "LFR+HFR" because the CDAWeb files actually combines both the LFR and HFR into one single array so, i thought "LFR+HFR" would may be right name the detector

Keeping this reader is the best! Maybe at one point we can add readers for the LFR and HFR data separately as they won't work by default with this one but, that can be for a different and future PR
from the CDF file it looks like it could be L3 data which was surprising @hayesla (Data_type : ['L3>Level 3'])
https://gist.github.com/Hermanlrx/0f149107efdb3c29e44759ae894c3294

radiospectra shouldn't be changing the data only loading so if the file is combined leave it but this could make nice gallery example later showing how to split using crop_by_values.

ok sounds good @Amityush-lgtm ! maybe open an issue to add support for the LFR/HFR seperate files @Hermanlrx and that can be in another PR

Sounds good, I'll open the issue right away

radiospectra shouldn't be changing the data only loading so if the file is combined leave it but this could make nice gallery example later showing how to split using crop_by_values.

Should i add this in the issue or make a seperate issue for this?

hayesla · 2026-07-31T07:53:41Z

+
+                    meta = {
+                        "cdf_globals": cdf_globals,
+                        "detector": "LFR+HFR",


ok sounds good @Amityush-lgtm ! maybe open an issue to add support for the LFR/HFR seperate files @Hermanlrx and that can be in another PR

Amityush-lgtm added 2 commits July 7, 2026 01:08

add CDAWeb cdf support for WIND and STEREO

a50b2d7

Adding changelog

bcee7fb

Amityush-lgtm changed the title ~~add CDAWeb cdf support for WIND and STEREO~~ Add CDAWeb CDF support for WIND and STEREO Jul 7, 2026

samaloney reviewed Jul 7, 2026

View reviewed changes

use fill value for assignment and convert to unit

fa6139e

hayesla requested changes Jul 13, 2026

View reviewed changes

Comment thread radiospectra/spectrogram/spectrogram_factory.py Outdated

Comment thread radiospectra/spectrogram/spectrogram_factory.py

Comment thread radiospectra/spectrogram/spectrogram_factory.py Outdated

Comment thread radiospectra/spectrogram/spectrogram_factory.py

Applying suggestions from @hayesla

141cacb

samaloney reviewed Jul 15, 2026

View reviewed changes

Comment thread radiospectra/spectrogram/spectrogram_factory.py

Amityush-lgtm requested a review from hayesla July 17, 2026 18:24

hayesla approved these changes Jul 22, 2026

View reviewed changes

Amityush-lgtm mentioned this pull request Jul 23, 2026

Fix wavelength attribute calculation across spectrogram sources #257

Open

Amityush-lgtm added 2 commits July 26, 2026 10:00

Merge branch 'main' into add-cdaweb-support

a2c62dd

ignore warning

d1a2f42

Hermanlrx reviewed Jul 28, 2026

View reviewed changes

hayesla approved these changes Jul 31, 2026

View reviewed changes

Hermanlrx approved these changes Jul 31, 2026

View reviewed changes

Amityush-lgtm mentioned this pull request Jul 31, 2026

Add support for separate LFR and HFR files for STEREO S/WAVES #260

Open

Merge branch 'main' into add-cdaweb-support

ff8b9ca

Amityush-lgtm requested a review from samaloney August 12, 2026 14:55

Amityush-lgtm added 2 commits August 19, 2026 11:52

Merge branch 'main' into add-cdaweb-support

4bc6b4b

Merge branch 'main' into add-cdaweb-support

9cadd84

Uh oh!

Uh oh!

Conversation

Amityush-lgtm commented Jul 7, 2026

PR Description

AI Assistance Disclosure

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amityush-lgtm Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amityush-lgtm commented Jul 7, 2026

Uh oh!

hayesla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Amityush-lgtm commented Jul 13, 2026

Uh oh!

Uh oh!

Amityush-lgtm commented Jul 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Amityush-lgtm Jul 7, 2026 •

edited

Loading