-
-
Notifications
You must be signed in to change notification settings - Fork 53
Tidy NDCube tests #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tidy NDCube tests #844
Conversation
…and mul with nddata. ALso add new arithmetic add with nddata test, which more concisely covers test cases.
@nabobalis or @Cadair: Any objection to splitting up the |
ndc + value | ||
|
||
|
||
@pytest.mark.parametrize(("ndc", "value", "expected_kwargs"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PCJY Will you give this function and the multiply
test below a quick review? Just take a look and ask questions about anything you don't understand. If you happen to find any problems, please point those out too.
In summary, I replaced all the __add__
tests (except test_arithmetic_add_one_unit
) with this one, which is similar to your multiply
test below. That's because the code and logic tree is much simpler than when you first wrote the tests.
I also added an extra case in the parameterizations of your multiply test to catch all the cases.
I see no issue with splitting up test files to make it clear what each file is testing. |
PR Description
This PR breaks test_ndcube.py into multiple files based on the functionalities being tested, as the file was becoming unwieldy.
DO NOT merge until after #840
To Do