Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): add non-interactively mode to rename command #996

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

sunny0826
Copy link
Owner

Description

add non-interactively mode to rename command

Related Issue

resolves #993

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@sunny0826 sunny0826 added the kind/feature ategorizes issue or PR as related to a new feature. label Jul 31, 2024
Copy link

the-label-bot bot commented Jul 31, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label

@sunny0826 sunny0826 self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 20.68%. Comparing base (1cbcc80) to head (d07b721).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/rename.go 30.76% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   20.53%   20.68%   +0.15%     
==========================================
  Files          21       21              
  Lines        2167     2185      +18     
==========================================
+ Hits          445      452       +7     
- Misses       1675     1686      +11     
  Partials       47       47              
Flag Coverage Δ
unittests 20.68% <30.76%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunny0826 sunny0826 merged commit 90d08f1 into master Aug 1, 2024
6 checks passed
@sunny0826 sunny0826 deleted the feat/rename-args branch August 1, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Interactive kubecm rename: kubecm rename {existing-name} {new-name}
1 participant