Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #888 #967

Merged
merged 6 commits into from
Jun 7, 2024
Merged

fixing issue #888 #967

merged 6 commits into from
Jun 7, 2024

Conversation

AdamRussak
Copy link
Contributor

@AdamRussak AdamRussak commented Jun 6, 2024

Description

fixing #888

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@the-label-bot the-label-bot bot added kind/documentation Improvements or additions to documentation size/M size/M labels Jun 6, 2024
Copy link

the-label-bot bot commented Jun 6, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.834 ✔️
Size L 0.873 ✔️

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 20.56%. Comparing base (13fbf30) to head (225031e).

Files Patch % Lines
cmd/utils.go 87.09% 2 Missing and 2 partials ⚠️
cmd/root.go 0.00% 2 Missing ⚠️
cmd/add.go 0.00% 1 Missing ⚠️
cmd/merge.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   19.68%   20.56%   +0.88%     
==========================================
  Files          21       21              
  Lines        2134     2164      +30     
==========================================
+ Hits          420      445      +25     
- Misses       1670     1673       +3     
- Partials       44       46       +2     
Flag Coverage Δ
unittests 20.56% <77.14%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, just need to add some unit tests.

cmd/utils.go Show resolved Hide resolved
@the-label-bot the-label-bot bot added size/L size/L and removed size/M size/M labels Jun 7, 2024
@AdamRussak
Copy link
Contributor Author

@sunny0826 done..
i dont see a reason to add e2e, as this is already part of the tests so it is tested.

@sunny0826
Copy link
Owner

@sunny0826 done.. i dont see a reason to add e2e, as this is already part of the tests so it is tested.

yep, there is no need to add e2e test to this bug fix

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆

@sunny0826 sunny0826 merged commit 561e01c into sunny0826:master Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation size/L size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants