Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Rancher #331

Merged
merged 1 commit into from
May 17, 2022
Merged

Provider Rancher #331

merged 1 commit into from
May 17, 2022

Conversation

futuretea
Copy link
Contributor

@futuretea futuretea commented May 16, 2022

Signed-off-by: futuretea [email protected]

After we support rancher, the following clusters will be support in kubecm

  1. cluster imported to Rancher
  2. cluster created by Rancher
    image

Related issues
#44

Signed-off-by: futuretea <[email protected]>
@futuretea futuretea changed the title Provider rancher Provider Rancher May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #331 (a4ff4a8) into master (a3f2a25) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   11.92%   11.54%   -0.38%     
==========================================
  Files          17       17              
  Lines        1619     1671      +52     
==========================================
  Hits          193      193              
- Misses       1409     1461      +52     
  Partials       17       17              
Flag Coverage Δ
unittests 11.54% <0.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cloud.go 6.18% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f2a25...a4ff4a8. Read the comment docs.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunny0826 sunny0826 merged commit 04e8348 into sunny0826:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants