Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the drop-shadow on 'single-hadith-view' navigation buttons #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tawfiqh
Copy link

@Tawfiqh Tawfiqh commented Aug 28, 2020

Reduced the drop-shadow on 'single-hadith-view' navigation buttons

Now consistent with the 'actualHadithContainer' css class and the overall flat-design of the page.

Reduced the drop-shadow on 'single-hadith-view' navigation buttons 

Now consistent with the 'actualHadithContainer' css class and the overall flat-design of the page.
@ahadith
Copy link
Contributor

ahadith commented Aug 28, 2020

Salaam @fsid - Thoughts? Also can you please take a look and see if any additions need to be made for the other screen sizes?

@fsid
Copy link
Collaborator

fsid commented Aug 28, 2020

Wa Alaikumussalaam,

JazakAllah for the PR @Tawfiqh

The idea behind a prominent shadow was to add depth perception. We wanted the buttons showing more height because they needed to stand out, but not catch too much attention. also to differentiate better from the background. I see the idea behind creating consistency and agree. Perhaps there is a happy compromise in the middle?

@ahadith ahadith assigned fsid and unassigned fsid Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants