[14.0] [ADD] mass_merge #1
Conversation
…module=record_merge)
…module=record_merge)
…x into 14.0-add-mass-merge # Conflicts: # mass_merge/__manifest__.py # mass_merge/models/__init__.py # mass_merge/models/merge_editing.py # mass_merge/wizard/__init__.py
…product_combination_unique
| # fields are to be used to to match | ||
| class BaseMergeModel(models.Model): | ||
|
|
||
| _name = 'base.merge.model' |
There was a problem hiding this comment.
Add description
_description = 'Base Merge Model'
|
|
||
| domain = fields.Char(string="Filter", required=True) | ||
| key = fields.Text(string="Group key", required=True, | ||
| help="The key that will be used to group the records to merge." |
There was a problem hiding this comment.
Hey @Kiplangatdan I don't see any indentation issue here.
There was a problem hiding this comment.
Indent the same way as the other fields. (But also put in all fields the final ) on a separate line and put a comma also after the last keyword. Unless a field definition fits all on one line (that is in 88 positions).
|
|
||
| model_name = fields.Char(string="Model name", related="model_id.model") | ||
|
|
||
| merge_relation_id = fields.Many2one('record.merge.relation.field', string="Origin Relation") |
There was a problem hiding this comment.
Same case here, identation.
There was a problem hiding this comment.
Also here, I don't see any indentation issue.
|
@douglas-tabut Please attend to the above meanwhile. |
| @@ -0,0 +1,30 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
What happens in this init hook is more properly done by a data xml, or even better as demo data.
mass_merge/models/__init__.py
Outdated
| @@ -0,0 +1,10 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
In Odoo 14.0 (since 11.0) we should no longer have coding lines in python files.
| @@ -0,0 +1,81 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # © 2020 Therp BV <https://therp.nl> | |||
There was a problem hiding this comment.
use the word Copyright, not a character
| from odoo import _, api, fields, models | ||
|
|
||
|
|
||
| # This class holds configuration about which models |
There was a problem hiding this comment.
Make this into a proper class doc comment.
| @@ -0,0 +1,18 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
What is the need for this file? Just one call to a super method without any extra action, all arguments passed unchanged...
| self.fill_group() | ||
|
|
||
|
|
||
| class RecordMergeCriteriaGroup(models.Model): |
There was a problem hiding this comment.
Each model class should have its own file.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@douglas-tabut I rebased this branch and opened a new MR, that takes care of most of the review comments and makes the module installable and somewhat functional. Please take a look here #2 |
TA#60999 [14.0][FIX]date_range: store date_end in date.range.generator
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.