Created generic for hashers #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Luca， Can you please add xxh3 as a feature so that the hasher you added can call hash64_with_seed() in xxh3. Thanks, Jianshu |
|
I am not sure I understood, you can pass as a generic whatever you want. There is no need to add dependencies. |
sundy-li
reviewed
Aug 21, 2024
That looks better to me. There are numerous hash crates, we don't need too many deps and features cause the |
|
please use cargo fmt format the codes. ut is failed now. |
dosubot
bot
added
the
size:M
sundy-li
reviewed
Sep 18, 2024
|
|
||
| /// By default, we use 2**14 registers like redis | ||
| const DEFAULT_P: usize = 14_usize; | ||
|
|
||
| /// Fixed seed | ||
| const SEED: RandomState = RandomState::with_seeds( |
There was a problem hiding this comment.
Removing these will cause incompatiable changes.
We need to use fixed seed.
|
I am not sure what died there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #2, introducing a generic for arbitrary hashers. The default remains as before a seeded AHasher, but using the Default seeds from the library itself.