Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional feature mem-dbg #1

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

LucaCappelletti94
Copy link
Contributor

As per the title, I have added mem_dbg as an optional feature to make it easy to compare the memory requirements of this library with others.

Cheers!

Luca

@sundy-li sundy-li merged commit 1da867c into sundy-li:main Aug 16, 2024
5 of 7 checks passed
@sundy-li
Copy link
Owner

CI is not passed, I revert this pr. You can send another pr to improve it.

cargo test --all-features    
rror[E0425]: cannot find function `size_of` in this scope
   --> /Users/sundy/.cargo/registry/src/github.com-1ecc6299db9ec823/mem_dbg-0.2.4/src/impl_mem_size.rs:672:17
    |
672 |                 size_of::<usize>()
    |                 ^^^^^^^ not found in this scope
    |

@LucaCappelletti94
Copy link
Contributor Author

Which Rust version are you using?

@LucaCappelletti94
Copy link
Contributor Author

Apparently they have already fixed this issue in mem-dbg, only the guy that owns the derive variant of the crate is in vacation and have yet to publish it.

@LucaCappelletti94
Copy link
Contributor Author

I will make a new PR when it is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants