Skip to content

Commit

Permalink
Merge pull request #5229 from sul-dlss/5228-stt-disable-lock
Browse files Browse the repository at this point in the history
check speechToTextWF for assembling
  • Loading branch information
jmartin-sul authored Nov 13, 2024
2 parents b461410 + 225ee98 commit 0e798a3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/services/workflow_state_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def assembling?
active_workflow_except_step?(workflow: 'wasSeedPreassemblyWF', process: 'end-was-seed-preassembly') ||
active_workflow_except_step?(workflow: 'gisDeliveryWF', process: 'start-accession-workflow') ||
active_workflow_except_step?(workflow: 'ocrWF', process: 'end-ocr') ||
active_workflow_except_step?(workflow: 'speechToTextWF', process: 'end-stt') ||
active_workflow?(workflow: 'gisAssemblyWF')
end

Expand Down
15 changes: 15 additions & 0 deletions spec/services/workflow_state_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
let(:gis_delivery_wf_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: false) }
let(:gis_assembly_wf_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: false) }
let(:ocr_wf_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: false) }
let(:stt_wf_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: false) }
let(:process) { instance_double(Dor::Workflow::Response::Process, name: 'arbitrary') }

before do
Expand All @@ -94,6 +95,7 @@
allow(workflow_client).to receive(:workflow).with(pid: druid, workflow_name: 'gisDeliveryWF').and_return(gis_delivery_wf_response)
allow(workflow_client).to receive(:workflow).with(pid: druid, workflow_name: 'gisAssemblyWF').and_return(gis_assembly_wf_response)
allow(workflow_client).to receive(:workflow).with(pid: druid, workflow_name: 'ocrWF').and_return(ocr_wf_response)
allow(workflow_client).to receive(:workflow).with(pid: druid, workflow_name: 'speechToTextWF').and_return(stt_wf_response)
end

context 'when there is an active assemblyWF' do
Expand Down Expand Up @@ -168,19 +170,31 @@
end
end

context 'when there is an active speechToTextWF' do
before do
allow(stt_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [process, process])
end

it 'returns true' do
expect(workflow_state).to be_assembling
end
end

context 'when only ignored steps are incomplete' do
let(:accessioning_initiate_process) { instance_double(Dor::Workflow::Response::Process, name: 'accessioning-initiate') }
let(:end_was_crawl_process) { instance_double(Dor::Workflow::Response::Process, name: 'end-was-crawl-preassembly') }
let(:end_was_seed_process) { instance_double(Dor::Workflow::Response::Process, name: 'end-was-seed-preassembly') }
let(:start_accession_process) { instance_double(Dor::Workflow::Response::Process, name: 'start-accession-workflow') }
let(:end_ocr_process) { instance_double(Dor::Workflow::Response::Process, name: 'end-ocr') }
let(:end_stt_process) { instance_double(Dor::Workflow::Response::Process, name: 'end-stt') }

before do
allow(assembly_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [accessioning_initiate_process])
allow(was_crawl_preassembly_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [end_was_crawl_process])
allow(was_seed_preassembly_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [end_was_seed_process])
allow(gis_delivery_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [start_accession_process])
allow(ocr_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [end_ocr_process])
allow(stt_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [end_stt_process])
end

it 'returns false' do
Expand All @@ -195,6 +209,7 @@
allow(was_seed_preassembly_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [])
allow(gis_delivery_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [])
allow(ocr_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [])
allow(stt_wf_response).to receive_messages(active_for?: true, incomplete_processes_for: [])
end

it 'returns false' do
Expand Down

0 comments on commit 0e798a3

Please sign in to comment.