Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed both filters not applying together #179

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

DhruvChadha22
Copy link
Contributor

Related Issue

Fixes #77

Description

This PR fixes the issue where the left and right filters do not apply simultaneously.
The changes are made so that any filter is called on the filtered jobsList rather than allJobs. Also when removing a filter, the second filter is still kept.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joblane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 9:27am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sujaltangde sujaltangde merged commit 7f2f249 into sujaltangde:main Jul 10, 2024
3 checks passed
@DhruvChadha22
Copy link
Contributor Author

Hi @sujaltangde , could you please assign the gssoc and level labels to this PR as its required for the leaderboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Only one filter is applied at a time
2 participants