Improve upload performances and ui feedback #380
+36
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanVss
force-pushed
the
fix/upload-perf-ui
branch
2 times, most recently
from
9189699 to
30c8ad6
Compare
NathanVss
requested review from
PanchoutNathan and
lunika
and removed request for
lunika
lunika
approved these changes
Oct 27, 2025
The previous implementation was taking a long time to read first bytes of large files. For example it was taking 40sec for a 750mb file. Let's use the s3 api to perform optimized operations.
The disclaimer was always shown even if no uploads are pending. Let's add a none state that means no uploads have been started yet.
NathanVss
force-pushed
the
fix/upload-perf-ui
branch
2 times, most recently
from
7a04e44 to
145de02
Compare
For large uploads, the upload-ended route was still pending and the file was displayed as "uploaded", at this point the user could refresh its page without any disclaimer. We want to wait for the upload-ended route to be resolved to tell that the progress is at 100%.
NathanVss
force-pushed
the
fix/upload-perf-ui
branch
from
145de02 to
23a0b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348
Various fixes here.