✨(back) integrate resource server API #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
force-pushed
the
feat/resource-server
branch
3 times, most recently
from
2a19602 to
238a83c
Compare
lunika
changed the title
lunika
force-pushed
the
feat/resource-server
branch
from
0758b5f to
75cf0c7
Compare
sylvinus
force-pushed
the
feat/resource-server
branch
from
33ca843 to
32dd759
Compare
qbey
reviewed
Jun 5, 2025
| ): | ||
| return False | ||
|
|
||
| # When used as a resource server, the request has a token audience |
Member
There was a problem hiding this comment.
The comment needs an update and so the docstring (class & method)
Comment on lines
37
to
50
| try: | ||
| payload = jwt.decode( | ||
| token, settings.JWT_SECRET_KEY, algorithms=[settings.JWT_ALGORITHM] | ||
| ) | ||
| except jwt.InvalidTokenError as e: | ||
| logger.error("Invalid JWT token: %s", e) | ||
| return None | ||
|
|
||
| if not payload.get("sub") or not payload.get("email"): | ||
| logger.warning("Invalid JWT token. Missing 'sub' or 'email' in payload") | ||
| return None |
Member
There was a problem hiding this comment.
Be carreful here, because the OIDC authentication can also use the "Bearer" format, and provide a JWT (the OIDC access token can be a JWT), so you will log error and warning even for valid OIDC authentication.
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class JWTAuthentication(authentication.BaseAuthentication): |
Member
There was a problem hiding this comment.
You may add a authenticate_header method to return a 401 instead of a 403 when no authentication is provided.
sylvaingi
force-pushed
the
feat/resource-server
branch
2 times, most recently
from
a820d78 to
24a7a15
Compare
We expose now an external API. This external API can be used using a resource server authentication. The urls are prefixed with /external_api/v1.0 and for now the viewsets available are the Item and ItemAccess.
The mozilla OIDCAuthentication backend was configured in the DRF settings but not used. We have to remove it.
The external_api prefix must be managed by an ingress to use the correct backend, the impress-backend one.
We want to allow temporarily the connection of the external API using a JWT token with a simmetric key. This simmetric key must be used with the system allowed to request drive.
By introducing an other authentication class the status code has changed from 401 to 403. All new code added since june must be updated.
lunika
force-pushed
the
feat/resource-server
branch
from
24a7a15 to
105dbd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Expose endpoints for external api. This endpoints will allow to work on the
itemanditemAccessresources.The external apis are available with these urls:
To authenticate to this API, the request must have a Bearer token provided by your OIDC provider when the user is connected. The authentication will introspect the given token by fetching an introspection endpoint provided by your OIDC provider.
To configure your instance, you can follow this documentation: https://github.com/suitenumerique/django-lasuite/blob/main/documentation/how-to-use-oidc-resource-server-backend.md