Skip to content

Conversation

virgile-dev
Copy link
Collaborator

@virgile-dev virgile-dev commented Sep 12, 2025

Purpose

To move a doc you have to be at least admin of the destination doc.
It was written editor in the alert banner.

Proposal

Change editor for administrator

@virgile-dev
Copy link
Collaborator Author

In the making of the PR I was thinking that the current permission setting is confusing.
We allow editors to create sub-docs why not allow them to move docs inside a document where they are editors. I feel we should change the permissions not the message. @lunika

Copy link

github-actions bot commented Sep 12, 2025

Size Change: +1 B (0%)

Total Size: 3.65 MB

Filename Size Change
apps/impress/out/_next/static/c625dd85/_buildManifest.js 0 B -864 B (removed) 🏆
apps/impress/out/_next/static/2e5446cc/_buildManifest.js 864 B +864 B (new file) 🆕

compressed-size-action

@lunika
Copy link
Member

lunika commented Sep 16, 2025

In the making of the PR I was thinking that the current permission setting is confusing. We allow editors to create sub-docs why not allow them to move docs inside a document where they are editors. I feel we should change the permissions not the message. @lunika

True. But it depends on the target position maybe ? Should we allow the "Move to my docs" for editors too ?
We should probably take the time to think about other situation where an admin role is needed and you can already do more or less the same thing as an editor.

@AntoLC AntoLC added the bug Something isn't working label Sep 16, 2025
@virgile-dev virgile-dev force-pushed the fix-move-permission-copy branch from 4ca1ebe to 2fdda73 Compare September 19, 2025 10:08
@virgile-dev virgile-dev enabled auto-merge (squash) September 19, 2025 10:09
To move a doc you have to be at least admin of the destination doc

Signed-off-by: virgile-deville <[email protected]>
@AntoLC AntoLC force-pushed the fix-move-permission-copy branch from 2fdda73 to 3dc91c2 Compare October 3, 2025 14:03
@virgile-dev virgile-dev merged commit ca10fb9 into main Oct 3, 2025
20 of 22 checks passed
@virgile-dev virgile-dev deleted the fix-move-permission-copy branch October 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants