(frontend) fix callout block navigation issues & styles #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the callout block styles, centered the emoji and aligned the text to be in the center of the block. Signed-off-by: ZouicheOmar <[email protected]>
Fixed the behavior of arrow navigation around and between callout blocks. When navigating backwards (arrow up or left) from a callout that is either document's first block or comes right after a callout, the cursor doesn't go into a text selection, which it should. Similar behavior if when going forward. This bug is trigged by any of the four arrow keys. Added a command to set the cursor position as it is expected. Signed-off-by: ZouicheOmar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses issue #892.
Using the callout block can provoque cursor issues when using arrow for text navigation.
The cursor gets unexpected positions. This happens when the callout block is the first of
the document and the users tries to go up, and on all directions when the cursor is
between consecutive callout blocks.
This PR also updates minor styles for the callout block.
Proposal