Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#321 Social accounts open in new tab #322

Closed
wants to merge 2 commits into from

Conversation

himanshujaidka
Copy link

Now, it opens in a new tab

@himanshujaidka himanshujaidka changed the title Social accounts open in new tab issue#321 Social accounts open in new tab Jul 5, 2020
@quozl
Copy link
Contributor

quozl commented Jul 5, 2020

Why would anyone want that? Forces the user to close one more tab.

@himanshujaidka
Copy link
Author

Because it will easy for users who wants to compare one tab with another and many users will forget to close first tab that is sugarlabs tab and this website will remain open

@quozl
Copy link
Contributor

quozl commented Jul 6, 2020

Then they can use open in new tab feature.

@himanshujaidka
Copy link
Author

if they are using a mobile phone then

@himanshujaidka
Copy link
Author

In my point of view, it is more convenient for the user when the link automatically opens in a new tab :)

succesfully removed contribute to website link
@quozl
Copy link
Contributor

quozl commented Jul 6, 2020

This in conjunction with other recent issues and pull requests looks like a denial of service attack on our organisation. Could you please explain why you have become interested in our web site? Has someone asked you to be involved? Is there a bounty? Are we on some list somewhere? I'd like to get us removed from any such list.

@himanshujaidka
Copy link
Author

No! nothing like that :) Actually I want to take part in GSoC 2021 so for that I am preparing and I am very passionate about it. Would you mind if you will guide me and I also want to improve your website because I love to design websites :)

@quozl
Copy link
Contributor

quozl commented Jul 7, 2020

Thanks! Looking at your profile, we could really do with help on Sugar, Sugarizer and Music Blocks.

@himanshujaidka
Copy link
Author

ok

@olawanlejoel
Copy link
Contributor

But I believe opening social accounts on a new tab is very useful as it helps uses still maintain what they were previously going through. I know users can easily take the 'open on a new tab' route but would be cool if it's integrated.

The contributor can also add rel="noopener" with the target="_blank"

@samswag
Copy link
Member

samswag commented Aug 12, 2020

@olawanlejoel I agree too, but at the moment we are focusing on fixing some broken UI elements on the site. See #316

@himanshujaidka
Copy link
Author

I think it is also a part of UI @samswag

@himanshujaidka
Copy link
Author

ok @olawanlejoel I got it

@quozl quozl closed this Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants