Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Port to Python 3 #13

wants to merge 1 commit into from

Conversation

ayushnawal
Copy link

I will try to fix the issues listed by you asap.

@quozl
Copy link

quozl commented Dec 19, 2019

I've reviewed the activity source code, and I'm not willing to test or merge, as the activity has no use case that I can figure out.

@jdsimmons
Copy link
Contributor

jdsimmons commented Dec 19, 2019 via email

@quozl
Copy link

quozl commented Dec 19, 2019

Thanks, I agree. So no use case for more modern computers that have substantially more storage.

@jdsimmons
Copy link
Contributor

jdsimmons commented Dec 19, 2019 via email

@quozl
Copy link

quozl commented Dec 20, 2019

Thanks. So it could be enhanced to reach into Internet Archive to download and keep CBZ files?

@jdsimmons
Copy link
Contributor

jdsimmons commented Dec 20, 2019 via email

@quozl
Copy link

quozl commented Dec 22, 2019

Thanks. I don't mind either way; we just need a maintainer to step up to add CBS format support somewhere. I don't think we have that.

I wouldn't call this maintenance; @ayushnawal is apparently semi-automatically paying attention to all repositories with specific tasks in mind. It creates an illusion of maintenance, but the scope of work is so limited that there is often no useful outcome for the end users if the activity has other problems.

@srevinsaju
Copy link
Member

@quozl, volunteering to add CBZ support for GetIABooksActivity, shall I proceed?

@quozl
Copy link

quozl commented Jan 31, 2020

Thanks for the offer.

I've listened to school librarian podcasts recently where graphic novels and comic books were discussed, and they have significant pedagogical value, by engaging alternate paths to understanding.

I suggest instead making a comics-specific activity, if necessary by forking one of the two get books activities.

Read activity claims support for content type application/x-cbz. Please also check that the Read activity can display the files?

Apart from Internet Archive, are there other collections of CBZ files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants