Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #2645 Better Faux Pickup Support #4068

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

FIX #2645 Better Faux Pickup Support #4068

wants to merge 5 commits into from
+16 −11

Commits on Nov 21, 2024

  1. FIX sugarlabs#2645 Better Faux Pickup Support 

    Changes Made-

Added logic to handle non-negative pickup values and support "faux pickups" like 1/3.
Ensured notationPickup is called after setting the pickup value.

Validated the pickup value before passing it to MeterActions.setPickup to prevent errors.

Added input validation for pickup values in flow, ensuring only valid values are processed.
    @arth-1
    arth-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    81c7904 View commit details
    Browse the repository at this point in the history

  2. Updating rationalToFraction function to handle all the edge cases for… 

    … better error handling
    @arth-1
    arth-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5c5d796 View commit details
    Browse the repository at this point in the history

  3. Forgot to commit the Syntax error fix

    @arth-1
    arth-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d8e3fa2 View commit details
    Browse the repository at this point in the history

  4. removed warning messgae

    @arth-1
    arth-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    91db992 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. removed unnecesarry warning

    @arth-1
    arth-1 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2d81543 View commit details
    Browse the repository at this point in the history