Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test collab changes #4041

Draft
wants to merge 153 commits into
base: test-collab
Choose a base branch
from
Draft
Changes from all commits
Commits
Show all changes
153 commits
Select commit Hold shift + click to select a range
72097b8
fixes #3913
walterbender Jun 23, 2024
200dddb
fix:resolves grid position on hamburger opening(#3914) (#3924)
BeNikk Jun 28, 2024
71fe874
Merge branch 'master' into collaboration
apsinghdev Jul 1, 2024
423b467
Fix input boxes (#3927)
apsinghdev Jul 2, 2024
0d082eb
bump version
walterbender Jul 2, 2024
eb7c23a
enhancement: scale on hover (#3926)
Anas-2357 Jul 2, 2024
6354fa8
calculate frequencies from ratio
walterbender Jul 2, 2024
474f811
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender Jul 2, 2024
ad292d9
Merge branch 'master' into collaboration
apsinghdev Jul 3, 2024
5848e62
Add close button to extended-menu pie menu (fixes #3933) (#3934)
BeNikk Jul 3, 2024
10ab05e
Bump braces and gulp (#3903)
dependabot[bot] Jul 3, 2024
5e27904
add support for solfege accidentals in phrasemaker
walterbender Jul 4, 2024
3c57c4b
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender Jul 4, 2024
530f330
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Jul 4, 2024
f73597e
Merge branch 'master' into collaboration
apsinghdev Jul 4, 2024
5022721
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Jul 7, 2024
55570e8
Add support for cents (#3937)
walterbender Jul 7, 2024
f88955e
Ratio transpose and Ratio interval (#3936)
walterbender Jul 7, 2024
97e811a
fix note convert
walterbender Jul 7, 2024
cba02d3
remove extra comma throwing off indexing
walterbender Jul 7, 2024
306888e
Merge branch 'master' into collaboration
apsinghdev Jul 9, 2024
2d99514
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Jul 10, 2024
944bc2e
Hyperscore link update (#3939) (#3947)
therealharshit Jul 12, 2024
aaf0f6e
Update Hyperscore example link in guide.html (#3944)
GeetenParab Jul 12, 2024
c41d9f5
Update README.md (#3943)
akilesh1706 Jul 12, 2024
69f8ee8
left_and_back_images (#3950)
khadar1020 Jul 15, 2024
472ec5c
Updated Dockerfile (#3949)
akilesh1706 Jul 15, 2024
cc0b986
Merge branch 'master' into collaboration
apsinghdev Jul 16, 2024
08787e1
remove yjs and socket.io dependecies
apsinghdev Jul 16, 2024
8776750
Fixed #3956 Auto increasing and decreasing input block (#3957)
therealharshit Jul 25, 2024
6436c2f
fixes #3941
walterbender Jul 26, 2024
3b63768
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender Jul 26, 2024
c415d53
fixes #3958
walterbender Jul 26, 2024
cc4bcef
Merge branch 'master' into collaboration
apsinghdev Jul 27, 2024
3acc0b5
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Jul 27, 2024
07f9707
Fixes collapsed state of note block (#3961)
therealharshit Jul 28, 2024
fd39015
Merge branch 'master' into collaboration
apsinghdev Jul 28, 2024
de9bd23
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Jul 29, 2024
72dcdea
fixes issue with extra line number in JavaScript Editor (#3962)
haroon10725 Jul 30, 2024
fdbd3ff
Merge branch 'master' into collaboration
apsinghdev Aug 1, 2024
8105355
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Aug 3, 2024
25a54b0
fixes sample block duplication issue (#3965)
haroon10725 Aug 5, 2024
5c94784
Merge branch 'master' into collaboration
apsinghdev Aug 6, 2024
0e59d72
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Aug 7, 2024
569efca
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Aug 11, 2024
e0a3e3e
updated planet image on documentation (#3971)
haroon10725 Aug 14, 2024
4acea66
fix 1MB file size limit on audio sample imports (#3976)
haroon10725 Aug 18, 2024
a995ff9
update wheelnav.js (#3977)
haroon10725 Aug 20, 2024
87bcbba
Fixes #3972 Highlight should not activate when code is being run (#3975)
therealharshit Aug 20, 2024
4ff5b98
removed extra code (#3980)
haroon10725 Aug 22, 2024
f5f616f
Fixes #3973 Right click menu only opens in the advanced mode (#3978)
AnupamGaur Aug 22, 2024
38ed1f2
FIXES ISSUE #3895 Add alphabet "G" as a block found in easy mode (#3…
omsuneri Aug 22, 2024
6f620f0
AI BLOCK and Documentation on How to add widget in MB (#3964)
abhijeetsingh0401 Aug 25, 2024
411cd87
Added midi support to MB (#3904)
Mubashirshariq Aug 26, 2024
205ad71
modifications for clarity
walterbender Aug 26, 2024
5af39d2
Merge branch 'master' into collaboration
apsinghdev Aug 27, 2024
c26a2d2
add abacus example
walterbender Aug 28, 2024
9f82b1f
Rhythm block doesn't repeat issue update (#3982)
therealharshit Aug 28, 2024
c807bc3
add more steps to new palette instructions
walterbender Aug 28, 2024
1f3e27f
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender Aug 28, 2024
ed2d7dd
Merge branch 'master' into collaboration
apsinghdev Aug 29, 2024
178f09f
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Aug 29, 2024
0c27d0c
fix: remove redundant code to achieve DRY consistency (#3988)
haroon10725 Aug 31, 2024
a531b75
Merge branch 'master' into collaboration
apsinghdev Sep 1, 2024
876df65
update block.js (#3989)
haroon10725 Sep 1, 2024
1830b47
refactor: Simplify note processing logic, remove an empty file (#3991)
retrogtx Sep 2, 2024
16dc86e
Update drum block setup to make it more compact (#3992)
retrogtx Sep 3, 2024
54ff472
refactor: update indexOf () === -1 to ! includes (#3993)
haroon10725 Sep 8, 2024
011678d
used regex to shrink code (#3996)
retrogtx Sep 8, 2024
a6f3514
introduced a setupFunctions array to group all the setup function cal…
retrogtx Sep 8, 2024
998c86e
Revert "introduced a setupFunctions array to group all the setup func…
walterbender Sep 9, 2024
923b9ba
Merge branch 'master' into collaboration
apsinghdev Sep 9, 2024
a06b9e0
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Sep 11, 2024
f410648
move all saved state into a single object (#3998)
retrogtx Sep 12, 2024
9e62e67
refactor: update indexOf () === -1 to ! includes (#4001)
haroon10725 Sep 13, 2024
30b5c47
ABC to MB Parser (#3925)
abhijeetsingh0401 Sep 13, 2024
5334127
clean up javascript formatting
walterbender Sep 13, 2024
77014c7
Merge branch 'master' into collaboration
apsinghdev Sep 14, 2024
3a1010f
Feat/add record button and playback button in sampler widget (#3813)
Mubashirshariq Sep 14, 2024
ff2b5bf
FIXES ISSUE #4000 Regression: 'Set Default Instrument' Block Converts…
omsuneri Sep 14, 2024
2f545e2
Add More Frequent "RUN LIVE" Links to Music Blocks Programming Guide …
dubeanant Sep 15, 2024
bd6561f
use object lookup for convertDuration instead of switch (#4003)
retrogtx Sep 16, 2024
8d2309d
Merge branch 'master' into collaboration
apsinghdev Sep 18, 2024
afc3c3f
Streamline Drumname for early return of drum post http match, use obj…
retrogtx Sep 22, 2024
27b8ecd
Merge branch 'master' into collaboration
apsinghdev Sep 23, 2024
4bafbba
FIXES ISSUE #3921 Reexamine our default temperament list (#4010)
omsuneri Sep 23, 2024
f1ea5d7
Merge branch 'master' into collaboration
apsinghdev Sep 23, 2024
d8a43bd
[3851] - feat: msg on disconnect (#4011)
apsinghdev Sep 24, 2024
f59a166
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Sep 24, 2024
b660898
new strings
walterbender Sep 24, 2024
cb2931e
string repair
walterbender Sep 24, 2024
3260ade
new strings
walterbender Sep 24, 2024
3db5902
Merge branch 'master' into collaboration
apsinghdev Sep 26, 2024
d491654
add missing translation
walterbender Sep 26, 2024
2502f57
cleanup
walterbender Sep 26, 2024
0f28aaf
reuse strings
walterbender Sep 26, 2024
e0b0517
[3851] - feature: exit the user from collaboration on `New Project` a…
apsinghdev Sep 27, 2024
1db603d
update sampler.js (#4013)
haroon10725 Sep 27, 2024
92c09d7
fix all lint + Base64Encode errors (#4015)
retrogtx Sep 27, 2024
d3bba03
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Sep 28, 2024
b71a2a7
Merge branch 'master' into collaboration
apsinghdev Sep 28, 2024
4fdfa32
revert part of 4015
walterbender Sep 28, 2024
256f677
Fixed mouse event malfunctioning (#4021)
soumyaranjan-panda Oct 1, 2024
087cd49
FIXME: Implement pickup measures and multi-voice support in abc.js (#…
retrogtx Oct 4, 2024
bae54ef
Fix search box hover behavior replacing input text (#4027)
dubeanant Oct 4, 2024
5abca9c
Remove line as weblate has issue with parsing it.
chimosky Oct 4, 2024
d3aa273
Remove other comments
chimosky Oct 4, 2024
e404fd4
Revert "Remove line as weblate has issue with parsing it."
chimosky Oct 4, 2024
5301ee9
Weblate now parses po files.
chimosky Oct 4, 2024
36fa6b5
FIXES ISSUE #4018 More default EDOs for temperament (#4022)
omsuneri Oct 4, 2024
f491852
new strings
walterbender Oct 4, 2024
59df238
new strings
walterbender Oct 4, 2024
7346e05
add missing header strings
walterbender Oct 5, 2024
c0dbffe
FIXES ISSUE #4018 More default EDOs for temperament (#4029)
omsuneri Oct 5, 2024
3b9d521
Merge branch 'master' into collaboration
Oct 5, 2024
040fab4
fix all eslint errors along with base64encode error (#4030)
retrogtx Oct 7, 2024
8dd8c0a
fix eslint & renderLanguageSelectIcon logic (#4031)
retrogtx Oct 7, 2024
5e65117
Merge branch 'master' into collaboration
apsinghdev Oct 12, 2024
60113f0
docs: add documentation for collaboration functionality (#4034)
apsinghdev Oct 13, 2024
b4cad30
FIXES ISSUE #4025 Issue with refreshing Search Bar in the pallete men…
omsuneri Oct 13, 2024
4b29d1f
FIXES ISSUE #4012 Scalar Step doesn't work for default temperaments (…
omsuneri Oct 13, 2024
5d9f285
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Oct 19, 2024
6ea64d3
Merge branch 'master' into collaboration
apsinghdev Oct 19, 2024
b5be318
refactor: use better mapping logic in _setupBlocksContainerEvents (#…
retrogtx Oct 27, 2024
8f91980
Fixes #4038 Issue with Note Block collapsing (#4043)
AlessandroPosenato Nov 6, 2024
fdb66b4
refactor (#4042)
retrogtx Nov 6, 2024
0dff3ea
fix: base64encode error warning, extraction of common logic into a si…
retrogtx Nov 7, 2024
88fd12d
Fix input field to allow re-choosing the same file by clearing after …
urabhay10 Nov 10, 2024
672688f
Confirmation model added (#4045)
Yashgabani845 Nov 11, 2024
582b50c
Fixes issue: #4047 - circle closing when click on anywhere on the pag…
Meet-Thakkar21 Nov 13, 2024
926303d
palette sticky issue solved (#4055)
Yashgabani845 Nov 14, 2024
9793a7f
fix: maintain button visibility on window resize (#4054)
BeNikk Nov 14, 2024
e5f1dd1
Update `musicutils.js` reference (#4048)
emmanuel-ferdman Nov 14, 2024
21c77f6
#4056 correcting highlight problem near nav-bar (#4057)
krAtOsnana Nov 15, 2024
7d20f6f
Fixes #4056 Highlight should not activate near navbar (#4058)
therealharshit Nov 15, 2024
d58d3ae
FIXES ISSUE #4051 Add note piemenu opening behind the keyboard causin…
omsuneri Nov 16, 2024
2459733
increasing the size of chord pie menu (#4060)
omsuneri Nov 16, 2024
7ba9db9
relative --> absolute to fix selection regression
walterbender Nov 16, 2024
148a8ce
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender Nov 16, 2024
965da6a
Document Enhancement and Formatting Updates (#4069)
Ubayed-Bin-Sufian Nov 21, 2024
eadd178
Fix #2630: Add jsdoc style documentation (#4066)
retrogtx Nov 21, 2024
d63b7b1
Merge branch 'master' into collaboration
apsinghdev Nov 22, 2024
ec80db5
FIX #2645 Better Faux Pickup Support (#4068)
arth-1 Nov 22, 2024
506fa10
modify URL paths to test the collaboration using docker compose local…
apsinghdev Nov 22, 2024
49423ce
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev Nov 23, 2024
2f76e88
Merge branch 'master' into collaboration
apsinghdev Nov 24, 2024
f8830d2
FIXES #4070 The Pitch piemenu do not remember the last selected accid…
omsuneri Nov 24, 2024
55d3d47
Merge branch 'master' into collaboration
apsinghdev Nov 24, 2024
9fba47a
Make planet and collaboration docker friendly.
chimosky Oct 2, 2024
539352c
chore: make changes to run all the services
apsinghdev Oct 25, 2024
73d7494
Make planet and collaboration docker friendly.
chimosky Oct 2, 2024
0b9183c
update test-collab branch to contain all the logic to test the collab…
apsinghdev Nov 24, 2024
7f7ee8e
fix merge
apsinghdev Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 42 additions & 26 deletions js/piemenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const piemenuPitches = (
custom
) => {
let prevPitch = null;

let prevAccidental = block.prevAccidental || null; // to remember the previous accidental value
// wheelNav pie menu for pitch selection
if (block.blocks.stageClick) {
return;
Expand Down Expand Up @@ -334,30 +334,21 @@ const piemenuPitches = (

if (!custom) {
// Navigate to a the current accidental value.
if (accidental === "") {
block._accidentalsWheel.navigateWheel(2);
} else {
switch (accidental) {
case DOUBLEFLAT:
block._accidentalsWheel.navigateWheel(4);
break;
case FLAT:
block._accidentalsWheel.navigateWheel(3);
break;
case NATURAL:
block._accidentalsWheel.navigateWheel(2);
break;
case SHARP:
block._accidentalsWheel.navigateWheel(1);
break;
case DOUBLESHARP:
block._accidentalsWheel.navigateWheel(0);
break;
default:
block._accidentalsWheel.navigateWheel(2);
break;
}
}
let accidentalIndex = 2; // Default to "natural" if none is set.
if (prevAccidental !== null) {
accidentalIndex = accidentals.indexOf(prevAccidental);
} else if (accidental === DOUBLEFLAT) {
accidentalIndex = 4;
} else if (accidental === FLAT) {
accidentalIndex = 3;
} else if (accidental === NATURAL) {
accidentalIndex = 2;
} else if (accidental === SHARP) {
accidentalIndex = 1;
} else if (accidental === DOUBLESHARP) {
accidentalIndex = 0;
}
block._accidentalsWheel.navigateWheel(accidentalIndex);
}

if (hasOctaveWheel) {
Expand Down Expand Up @@ -605,7 +596,10 @@ const piemenuPitches = (
that.value += selection["attr"];
that.text.text = selection["note"] + selection["attr"];
}

// Store the selected accidental in the block for later use.
prevAccidental = selection["attr"];
block.prevAccidental = prevAccidental;

that.container.setChildIndex(that.text, that.container.children.length - 1);
that.updateCache();
__pitchPreview();
Expand All @@ -631,6 +625,28 @@ const piemenuPitches = (
// Hide the widget when the exit button is clicked.
block._exitWheel.navItems[0].navigateFunction = () => {
that._piemenuExitTime = new Date().getTime();
const selectedNote =
that._pitchWheel.navItems[that._pitchWheel.selectedNavItemIndex].title;
const selectedAccidental =
!custom && that._accidentalsWheel
? that._accidentalsWheel.navItems[that._accidentalsWheel.selectedNavItemIndex].title
: "";

// Update the block's displayed text with the note and accidental
if (selectedAccidental === "♮" || selectedAccidental === "") {
// Natural or no accidental: display only the note
that.text.text = selectedNote;
} else {
// Combine note and accidental for display
that.text.text = selectedNote + selectedAccidental;
}
// Update the block value and refresh the cache
that.value = selectedNote + (selectedAccidental === "♮" ? "" : selectedAccidental);
// Ensure proper layering of the text element
that.container.setChildIndex(that.text, that.container.children.length - 1);
// Refresh the block's cache
that.updateCache();
// Hide the pie menu and remove the wheels
docById("wheelDiv").style.display = "none";
that._pitchWheel.removeWheel();
if (!custom) {
Expand Down