Changed block.js to update to ES6 syntax #3032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to issue #2629 |
walterbender
reviewed
May 4, 2022
| offScreen(boundary) { | ||
| return !this.trash && boundary.offScreen(this.container.x, this.container.y); | ||
| } | ||
| //changed to arrow |
There was a problem hiding this comment.
No need to insert these comments.. they are implicit in the PR and not useful to someone reading the code later.
walterbender
reviewed
May 4, 2022
| this.docks.push([obj[1][i][0], obj[1][i][1], "anyin"]); | ||
| } | ||
| } this.docks.push([obj[1][i][0], obj[1][i][1], "anyin"]); |
walterbender
reviewed
May 4, 2022
| @@ -758,18 +760,21 @@ class Block { | |||
|
|
|||
| switch (this.name) { | |||
| case "nameddoArg": | |||
| for (let i = 1; i < obj[1].length - 1; i++) { | |||
| //CHANGED | |||
| for (let i of obj[1].length - 1) { | |||
There was a problem hiding this comment.
does this work? i starts at 1, not 0.
walterbender
reviewed
May 4, 2022
| for (let i = 1; i < obj[1].length; i++) { | ||
| this.docks.push([obj[1][i][0], obj[1][i][1], "anyin"]); | ||
| //CHANGEd | ||
| for (let i of obj[1].length) { |
walterbender
reviewed
May 4, 2022
|
|
||
| for (let i = 1; i < that.protoblock.staticLabels.length; i++) { | ||
| //CHANGED | ||
| for (let i = 1 of that.protoblock.staticLabels.length) { |
walterbender
reviewed
May 4, 2022
|
|
||
| for (let i = 1; i < that.protoblock.staticLabels.length; i++) { | ||
| //CHANGED | ||
| for (let i of that.protoblock.staticLabels.length) { |
walterbender
reviewed
May 4, 2022
|
|
||
| for (let i = 1; i < this.protoblock.staticLabels.length; i++) { | ||
| //CHANGED | ||
| for (let i of this.protoblock.staticLabels.length) { |
walterbender
reviewed
May 4, 2022
| isNoHitBlock() { | ||
| return NOHIT.indexOf(this.name) !== -1; | ||
| } | ||
| //Changed to arrow |
There was a problem hiding this comment.
Not that it impacts the code, but changing the order of these functions makes it harder to review.
|
Sorry to take so long reviewing this... I somehow overlooked it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated some for loops and function definitions to ES6+ syntax.