Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to for in for loops #3006

Closed
wants to merge 1 commit into from
Closed

Changed to for in for loops #3006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions js/blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,19 +187,19 @@ function Blocks(activity) {

let palette;
// Regenerate all of the artwork at the new scale.
for (let blk = 0; blk < this.blockList.length; blk++) {
this.blockList[blk].resize(scale);
for (blk in this.blockList) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing let

blk.resize(scale);
}

this.findStacks();
for (let stack = 0; stack < this.stackList.length; stack++) {
this.adjustDocks(this.stackList[stack], true);
for (stack in this.stackList) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing let

this.adjustDocks(stack, true);
}

// Make sure trash is still hidden.
for (let blk = 0; blk < this.blockList.length; blk++) {
if (this.blockList[blk].trash) {
this.blockList[blk].hide();
for (blk in this.blockList.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing let

if (blk.trash) {
blk.hide();
}
}

Expand Down