blocks.js/ES6 syntax #2629

[jwalapc]

#2629
1)Converted all the function to arrow functions which now is in ES6 syntax.
Replace

...
function foo( ... ) {
...
function bar( ... ) {
...
}
...
}
...

with

...
function foo( ... ) {
...
const bar = ( ... ) => {
...
}
...
}
...

@walterbender please view this.

[walterbender]

In general, this looks good. A couple of things need addressing:
(1) in many places, you put two spaces after the ==. There should only be one space.
(2) in the blockSclae method, where you changed the scope of blk and stack, you need to remove the declarations on L187 and 188. And I think you missed a few places in that function where you need to then define blk and stack.

[walterbender]

And please be sure to test, esp. the block scaling code, where you are making somewhat more invasive changes. Please report the results of your tests here.

[jwalapc]

In general, this looks good. A couple of things need addressing:
(1) in many places, you put two spaces after the ==. There should only be one space.
(2) in the blockSclae method, where you changed the scope of blk and stack, you need to remove the declarations on L187 and 188. And I think you missed a few places in that function where you need to then define blk and stack.

1. In first point you are saying about the arrow operator right? and can you say me 1 where I gave two spaces?
2. In 2nd point I should remove the 'let" right ? Because it is globally declared right ?
   @walterbender

[jwalapc]

And please be sure to test, esp. the block scaling code, where you are making somewhat more invasive changes. Please report the results of your tests here.

And If you dont mind can you elaborate this ? I am actually new to this.

[jwalapc]

Will this work I have removed the declaration in L187 and 188 ?

[walterbender]

That looks correct.

Regarding testing, start with a "smoke test": does the program still open? Then try invoking some of the functions through the UX: show and hide blocks; resize the blocks; etc.

[jwalapc]

Completed the required changes and Formatted the entire file properly.
1)Tested the code by running,found zero errors
2)Tested some functions everything is proper
3)Guide me if any more changes needed.
@walterbender If everything is proper please merge it.

[walterbender]

b is referenced outside of the for loop. We cannot reduce its scope here.

[jwalapc]

Done with it please view it @walterbender

[jwalapc]

@walterbender please view the pr if its correct?

[walterbender]

In the future, please do not mix things up in your PRs. Your title suggests this is all about conversion to ES6 syntax and yet you incouded some variable scoping changes as well (which is where you introduced numerous errors). These should have been two separate PRs.

[walterbender]

merged

[jwalapc]

merged

Thanks @walterbender for helping me so much . Next Pr will be soon and I will Correct my mistakes.

[walterbender]

It is merged. But it looks odd because I made some changes to it locally along the way, so the last commit you made was in conflict If you check the commit logs you will see your commits.

…

On Sat, Aug 28, 2021, 9:01 PM Jwala ***@***.***> wrote: merged Thanks @walterbender <https://github.com/walterbender> for helping me so much . Next Pr will be soon and I will Correct my mistakes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2999 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6PXYN7NHVBCCYHVZXQRPLT7GBHBANCNFSM5CXGV2AQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.