BugFix and Refactor : widget/modewidget.js #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joykirat18
force-pushed
the
modewidget.js
branch
from
4498e3c
to
07c225e
Compare
|
@meganindya please review this. |
|
Audio still playing after closing widget |
meganindya
force-pushed
the
modewidget.js
branch
from
1942eed
to
8b0c317
Compare
joykirat18
force-pushed
the
modewidget.js
branch
from
8b0c317
to
3c3c615
Compare
meganindya
force-pushed
the
master
branch
2 times, most recently
from
6450e5e
to
23246b0
Compare
meganindya
force-pushed
the
modewidget.js
branch
from
3c3c615
to
0b1149e
Compare
|
Please hard reset to 0b1149e on your local system |
joykirat18
force-pushed
the
modewidget.js
branch
from
0b1149e
to
be5a5d5
Compare
|
The bug is fixed. Please have a look @meganindya |
meganindya
force-pushed
the
modewidget.js
branch
from
be5a5d5
to
9ace22d
Compare
meganindya
approved these changes
Jan 29, 2021
meganindya
added a commit
that referenced
this pull request
Jan 29, 2021
This reverts commit 0d4536c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Reference : #2767, #2609
Before Changes
The sound does not stops when the widget is closed. This can be seen in the video attached.
Screen.Recording.2021-01-27.at.2.51.19.AM.mov
After changes
Screen.Recording.2021-01-27.at.2.55.53.AM.mov