Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor:widget/statistics-lint, prettify and documentation #2770

Merged
merged 2 commits into from
Jan 24, 2021
Merged

refractor:widget/statistics-lint, prettify and documentation #2770

merged 2 commits into from
Jan 24, 2021

Conversation

abhishekkumar08
Copy link
Contributor

Refrence #2609, #2630, #2767

@abhishekkumar08
Copy link
Contributor Author

@meganindya Please look at this, all okay?

meganindya
meganindya reviewed Jan 24, 2021
View reviewed changes
Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't address all the linting errors and warnings. If your text editor supports syntax linting implicitly or via plugins it'll be easier for you to identify. I'll complete this one for reference.

@abhishekkumar08 abhishekkumar08 marked this pull request as ready for review January 24, 2021 11:13
@abhishekkumar08
Copy link
Contributor Author

@meganindya yeah okay, vscode do show the errors. Thanks for the review.

@meganindya
Copy link
Member

Pls observe a33861a

@meganindya meganindya merged commit 0c9f855 into sugarlabs:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganindya meganindya meganindya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekkumar08 @meganindya